Add optional report feature to error dialog #2229
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
christian-byrne
requested review from
Yorha4D,
KarryCharon,
DorotaLuna,
shinshin86 and
a team
as code owners
| @@ -69,7 +69,16 @@ | |||
| "command": "Command", | |||
| "keybinding": "Keybinding", | |||
| "upload": "Upload", | |||
| "export": "Export" | |||
| "export": "Export", | |||
| "submitErrorReport": "Submit Error Report (Optional)", | |||
There was a problem hiding this comment.
Can we move these translations to a sub-namespace? The g namespace should be used for some common translations that used in multiple places.
There was a problem hiding this comment.
Sure, thanks.
src/main.ts
Outdated
| @@ -24,6 +25,15 @@ const ComfyUIPreset = definePreset(Aura, { | |||
|
|
|||
| const app = createApp(App) | |||
| const pinia = createPinia() | |||
| Sentry.init({ | |||
| app, | |||
| dsn: 'https://e2d0c0bd392ffdce48e856c2a055f437@o4507954455314432.ingest.us.sentry.io/4508621568475136', | |||
There was a problem hiding this comment.
How does this dsn get generated? We should probably have it defined in vite (Probably as a env var that injected during build time) instead of hardcode it here.
There was a problem hiding this comment.
The dsn is generated when the Sentry project is created. From relevant section of docs:
If your application is shipped to client devices, if possible, we recommend having a way to configure the DSN dynamically. In an ideal scenario, you can "ship" a new DSN to your application without the customer downloading the latest version. We recognize that this may not always be practical, but we cannot offer further advice as this scenario is implementation specific.
Creating a new one entails no longer receiving messages from users on older versons.
In either case, I will define it in vite. That way I can also disable in test env I believe.
There was a problem hiding this comment.
It is now injected during build time via SENTRY_DSN var. I changed the release workflow to use a GH secret with same name. It will also be disabled in CI env now.
| __SENTRY_ENABLED__: JSON.stringify( | ||
| !(process.env.CI === 'true' || process.env.NODE_ENV === 'development') | ||
| ), | ||
| __SENTRY_DSN__: JSON.stringify(process.env.SENTRY_DSN || '') |
There was a problem hiding this comment.
Should we disable sentry when DSN is not specified?
There was a problem hiding this comment.
Yes. Good Idea.
This PR introduces an issue report panel that allows users to submit reports for encountered issues. Users can select the information to include using checkboxes, optionally provide contact details, and indicate whether they wish to be notified if their input helps resolve the issue or if they want follow-up support.
Currently, this form is integrated into the graph execution error dialog but is designed to be reusable in any component.
error-report.mp4
┆Issue is synchronized with this Notion page by Unito