Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]Missing Node Types #345

Closed
H0icky opened this issue Nov 26, 2024 · 3 comments · Fixed by #358
Closed

[Feature Request]Missing Node Types #345

H0icky opened this issue Nov 26, 2024 · 3 comments · Fixed by #358
Assignees
Labels
enhancement New feature or request

Comments

@H0icky
Copy link

H0icky commented Nov 26, 2024

Hi there. I want to discuss a new feature here.
When we load some workflow with missing node types. The node will show red and replace the name with undefined. Can we just remain the original the node name, or maybe just add a suffix of “[undefined]”. So that even we can't run the workflow, we can read the workflow and try to understand what's going on without running it. I think it's better for user to quickly read and understand the workflow.

Original issue link: comfyanonymous/ComfyUI#5770

@webfiltered webfiltered self-assigned this Nov 26, 2024
@webfiltered webfiltered added the enhancement New feature or request label Nov 26, 2024
@LukeG89
Copy link

LukeG89 commented Nov 26, 2024

As I commented on the other issue:
Yes, I agree. Whenever I try to help someone with their workflow, I can't figure anything out unless I have all the custom nodes installed.

If possible, it would be great to also see the widgets, so it is clearer what the problem might be (e.g. wrong models, wrong values, etc.).

@webfiltered
Copy link
Contributor

Yeah, that is pretty frustrating. I've ended up just reading the json in the past. Whilst full details are not saved to the workflow, quite a bit is, and showing anything other than a handful of eye-melting-red blobs will be a good start.

@webfiltered
Copy link
Contributor

p.s. Should have mentioned: one time-saver is simply right clicking the node - context menu should have the node type in tiny-text at the top. Proper solution is in the works, though.

@webfiltered webfiltered linked a pull request Dec 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants