-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign invalid node indicator #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gradient can (and should) be impl. directly by caching a CanvasGradient.
Customisable boundary indicator now used, replacing red background.
9c275d4
to
77a76fe
Compare
Rebase: Done Corners: So that's due to what is now ab83046. The previous setting was to simply double the rounded edges, which was close enough for what it was used for before - 6px. Math was was only off by 2px. When you go up to 16px padding from the edge, it starts to look weird - the rounded corner is still the same as it was. With the new method, you get perfect alignment: Edit: Added a side-by-side comparison to the mention in the PR. |
Invalid node redesign
Configurable
Prefer orange?
Old indicator + title
Continues to be highly visible on busy workflows, even fully zoomed out:
API
drawSelectionBounding
=>strokeShape