Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom nodes not responding to changed widget values #333

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

webfiltered
Copy link
Contributor

@webfiltered webfiltered commented Nov 22, 2024

Resolves Comfy-Org/ComfyUI_frontend#1627

Logic for onWidgetChanged callback refactored to work in CanvasPointer callbacks.

@webfiltered webfiltered added this to the Pointer API milestone Nov 22, 2024
@huchenlei huchenlei merged commit a6c3f5c into master Nov 22, 2024
4 checks passed
@huchenlei huchenlei deleted the widget-change-cb branch November 22, 2024 15:48
@LukeG89
Copy link

LukeG89 commented Nov 23, 2024

@webfiltered I don't know which commit introduced this little bug, but in 1.4.7 doesn't happen.
Everytime I pass the mouse over these path widgets, they open like I double-click them.

Path.mp4

Debug logs:

E:\>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build --preview-size 1024 --front-end-version Comfy-Org/ComfyUI_frontend@latest
[START] Security scan
[DONE] Security scan
## ComfyUI-Manager: installing dependencies done.
** ComfyUI startup time: 2024-11-23 14:32:49.472348
** Platform: Windows
** Python version: 3.11.9 (tags/v3.11.9:de54cf5, Apr  2 2024, 10:12:12) [MSC v.1938 64 bit (AMD64)]
** Python executable: E:\python_embeded\python.exe
** ComfyUI Path: E:\ComfyUI
** Log path: E:\comfyui.log

Prestartup times for custom nodes:
   1.2 seconds: E:\ComfyUI\custom_nodes\ComfyUI-Manager

Total VRAM 8192 MB, total RAM 65277 MB
pytorch version: 2.6.0.dev20241115+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Ti Laptop GPU : cudaMallocAsync
Using pytorch cross attention
Initializing frontend: Comfy-Org/ComfyUI_frontend@latest, requesting version details from GitHub...
[Prompt Server] web root: E:\ComfyUI\web_custom_versions\Comfy-Org_ComfyUI_frontend\1.4.8
### Loading: ComfyUI-Impact-Pack (V7.11.5)
### Loading: ComfyUI-Impact-Pack (Subpack: V0.8)
[Impact Pack] Wildcards loading done.
### Loading: ComfyUI-Inspire-Pack (V1.7)
### Loading: ComfyUI-Manager (V2.51.9)
### ComfyUI Revision: 2855 [839ed336] | Released on '2024-11-22'
[comfyui_controlnet_aux] | INFO -> Using ckpts path: E:\ComfyUI\custom_nodes\comfyui_controlnet_aux\ckpts
[comfyui_controlnet_aux] | INFO -> Using symlinks: False
[comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json
DWPose: Onnxruntime with acceleration providers detected
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json
[ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json
WAS Node Suite: OpenCV Python FFMPEG support is enabled
WAS Node Suite: `ffmpeg_bin_path` is set to: /ffmpeg/bin
WAS Node Suite: Finished. Loaded 218 nodes successfully.

        "The secret to getting ahead is getting started." - Mark Twain


Import times for custom nodes:
   0.0 seconds: E:\ComfyUI\custom_nodes\loadImageWithSubfolders.py
   0.0 seconds: E:\ComfyUI\custom_nodes\websocket_image_save.py
   0.0 seconds: E:\ComfyUI\custom_nodes\stability-ComfyUI-nodes
   0.0 seconds: E:\ComfyUI\custom_nodes\ComfyUI_experiments
   0.0 seconds: E:\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus
   0.0 seconds: E:\ComfyUI\custom_nodes\ComfyUI_essentials
   0.0 seconds: E:\ComfyUI\custom_nodes\ComfyUI-Inspire-Pack
   0.1 seconds: E:\ComfyUI\custom_nodes\ComfyUI-VideoHelperSuite
   0.1 seconds: E:\ComfyUI\custom_nodes\comfyui_controlnet_aux
   0.3 seconds: E:\ComfyUI\custom_nodes\ComfyUI-Manager
   0.4 seconds: E:\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
   1.1 seconds: E:\ComfyUI\custom_nodes\was-node-suite-comfyui

Starting server

To see the GUI go to: http://127.0.0.1:8188

@webfiltered
Copy link
Contributor Author

Cheers! Would not have found that one organically - I use the upload node in places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants