Fix custom widget mouseover #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Nov 23, 2024
|
Ah sorry. Was trying to rush that out before I left. I'll update the PR. |
huchenlei
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #338
LGraphCanvas.node_widgetis set duringprocessMouseDown- a legacy state variable that is set to the last widget that was clicked. Cleared on pointerup.Some custom widgets expect to handle all pointer events, whilst others expect to only receive pointerdown events. The API was unclear, so guesswork appears to have been used.
Using node_widget, they should only receive movement events whilst dragging on the widget.