Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable interaction with links and reroutes when visibility is off #396

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

christian-byrne
Copy link
Contributor

Return early from drawConnections after clearing renderedPaths when link visibility is toggled off, fixing #392 and #394 and hiding reroutes alongside links.

Add checks to prevent reroute entries in the context menu and ignore reroute clicks when link visibility is disabled.

Before / After:

before-.mp4
after.mp4

@huchenlei huchenlei merged commit 57dd839 into Comfy-Org:master Dec 26, 2024
4 checks passed
@webfiltered webfiltered linked an issue Dec 26, 2024 that may be closed by this pull request
@christian-byrne christian-byrne deleted the bugfix/hidden-links branch December 26, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link-center context menu is interactable when links are hidden
2 participants