Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close prompt dialog popup on outer canvas click #80

Merged

Conversation

christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Aug 21, 2024

Close prompt dialogs by clicking elsewhere on canvas, consistent with how the litegraph context menus work. Currrently you have to click the OK button. Escape/Enter also work, but not if the element loses focus.

Resolves an issue on touch devices in which the OK button is rendered offscreen and the dialog is seemingly impossible to dismiss.

Touch device:

touch-device.mp4

Chrome and Firefox:

chrome-firefox.mp4

Related:

@huchenlei huchenlei merged commit f351b1d into Comfy-Org:master Aug 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants