Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding git commands to the game #83

Closed

Conversation

jacobdepriest
Copy link

Adding Git commands as an additional fifth "language"

@mwcz
Copy link
Member

mwcz commented Aug 9, 2019

This is awesome! Sorry I didn't see it sooner. This PR is simliar to #82 (add ansible commands) in that we don't have room on screen to fit all the languages. The existing 4 langs (js, html, bash, python) take up all the screen real estate during the "bonus command" screen.

Eventually I think we should change the game design to one where you choose the language you want. That would allow us to have as many langs as we want.

@jacobdepriest
Copy link
Author

I do see that it scrolls off the screen a little bit. I wonder if we could just adjust the font slightly to handle the Git and Ansible cases without having to do a redesign?

@mwcz
Copy link
Member

mwcz commented Aug 18, 2019

Changing the font size is opening a can of worms. Line breaks in the game text are manually added; there's no wrapping functionality. That means changing the text size requires manually reformatting every text string in the game. That's a big undertaking and it's really easy to miss things.

So, it's not impossible, but it is a lot of work.

@jacobdepriest
Copy link
Author

Fair enough. That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants