Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed SpeciesNetwork v0.12.2 #112

Closed
wants to merge 1 commit into from

Conversation

zhangchicool
Copy link
Contributor

@zhangchicool zhangchicool commented Feb 17, 2023

I have removed unavailable version (v0.12.2) of SpeciesNetwork in packages2.6.xml.

@rbouckaert
Copy link
Member

@zhangchicool What happened to SpeciesNetwork v0.12.2?
We would like to keep older versions of packages available in order to make runs replicable: if someone published an analysis with say version v0.1.0 of a packages, but the package has since been upgraded to v0.2.0, it cannot be guaranteed that the analysis still produces the same results. Even though there may be bug fixes in v0.2.0, and v0.1.0 may actually produce wrong results, given the analysis is published, it should be reproducable with the same software.

@zhangchicool
Copy link
Contributor Author

zhangchicool commented Feb 20, 2023

Hi Remco,
SpeciesNetwork v0.12.2 indeed contains a bug that prevents sampling a parameter, meaning that parameter is fixed to the initial state. It is not a serious bug, but i think reproducing this is not meaningful. I'd like to force users to use v0.13.0 (or newer) instead.
Anyway, I have removed the release of v0.12.2, and only kept v0.13.0 release (which is compatible with BEAST 2.5.x and 2.6.x), in my GitHub page. So the link to v0.12.2 is not working anymore. If people want to use v0.12.2, they can compile from the source code (under the tag of 0.12.2), so they can still reproduce things if they really want to.
Chi

@zhangchicool zhangchicool changed the title removed unavailable version of SpeciesNetwork in packages2.6.xml removed SpeciesNetwork v0.12.2 Feb 20, 2023
@rbouckaert
Copy link
Member

Hi Chi,

Thanks for the explanation. Bugs happen all the time, and of course we are aiming for not having any, but inevitably we keep on discovering things that are not what they should be. However, for replicability of science it is important to make it as easy as possible to reproduce published work, especially when we know there were some bugs: if it is not significant, it won't impact the results, but the only way to know is to run with and without the fix.

Asking users to rebuild from source to get a specific version does not seem very user friendly. Also, just because the version is missing from CBAN does not mean people cannot use it if already installed. BEAUti automatically checks for new versions (unless the user does not want this) so users will be prompted for new versions. This also means that by default the latest version will be installed, and you have to go through some effort to install older versions.

Anyway, I would appreciate it if you could reinstate v0.12.2 for the above reasons, instead of deleting them altogether.

Cheers, Remco

@zhangchicool
Copy link
Contributor Author

I've brought the file back, sorry for the trouble.

@zhangchicool zhangchicool deleted the patch-1 branch February 20, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants