Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial stubs #3

Merged
merged 7 commits into from
Nov 29, 2023
Merged

initial stubs #3

merged 7 commits into from
Nov 29, 2023

Conversation

stevenmcmanus-cocam
Copy link
Collaborator

@stevenmcmanus-cocam stevenmcmanus-cocam commented Nov 28, 2023 •
edited
Loading

PR Contains stubs / full implementations for endpoints we will be utilizing for this library. PR also contains initial JSDocs.

Stub implementation:

  • getCPUUsage
  • getRAMUsage
  • getThermalState

Full implementation:

  • getDiskUsage
  • getBatteryInfo
  • getCurrentVibe

Currently getCurrentVibe returns the full implementation values of getBatteryInfo and getDiskUsage, and the "faked" data from the rest.

aisflat439
aisflat439 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@aisflat439 aisflat439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stevenmcmanus-cocam stevenmcmanus-cocam marked this pull request as ready for review November 29, 2023 20:06
@stevenmcmanus-cocam stevenmcmanus-cocam merged commit ebd615b into main Nov 29, 2023
5 checks passed
@stevenmcmanus-cocam stevenmcmanus-cocam deleted the feature/endpoints-initial branch November 29, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aisflat439 aisflat439 aisflat439 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenmcmanus-cocam @aisflat439