Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github.com/openshift/library-go digest to fe56c2c #651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Jan 18, 2025

This PR contains the following updates:

Package Type Update Change
github.com/openshift/library-go require digest abb8c75 -> fe56c2c

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

openshift-ci bot commented Jan 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: renovate[bot]
Once this PR has been reviewed and has the lgtm label, please assign vincent056 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jan 18, 2025

Hi @renovate[bot]. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rhmdnd
Copy link

rhmdnd commented Jan 20, 2025

The library-go bump here is conflicting with the version of MCO we have:

 vendor/github.com/openshift/machine-config-operator/pkg/controller/common/controller_context.go:123:106: not enough arguments in call to events.NewKubeRecorder
	have ("k8s.io/client-go/kubernetes/typed/core/v1".EventInterface, string, *"k8s.io/api/core/v1".ObjectReference)
	want ("k8s.io/client-go/kubernetes/typed/core/v1".EventInterface, string, *"k8s.io/api/core/v1".ObjectReference, "k8s.io/utils/clock".PassiveClock) 

@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch 2 times, most recently from ac60aa3 to 98f01dc Compare January 22, 2025 12:27
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 7359be9 Update github.com/openshift/library-go digest to 4ea5029 Jan 22, 2025
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 4ea5029 Update github.com/openshift/library-go digest to 0f76e23 Jan 27, 2025
@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from 98f01dc to e879faa Compare January 27, 2025 13:04
Copy link
Author

renovate bot commented Jan 27, 2025

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 3 additional dependencies were updated

Details:

Package Change
github.com/openshift/api v0.0.0-20250120092857-366ffb8c60da -> v0.0.0-20250124212313-a770960d61e0
github.com/openshift/client-go v0.0.0-20241203091221-452dfb8fa071 -> v0.0.0-20250125113824-8e1f0b8fa9a7
k8s.io/kube-aggregator v0.31.1 -> v0.32.1

@renovate renovate bot force-pushed the renovate/github.com-openshift-library-go-digest branch from e879faa to 15abcd0 Compare January 30, 2025 01:19
@renovate renovate bot changed the title Update github.com/openshift/library-go digest to 0f76e23 Update github.com/openshift/library-go digest to fe56c2c Jan 30, 2025
Copy link

openshift-ci bot commented Jan 30, 2025

@renovate[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 15abcd0 link true /test verify
ci/prow/unit 15abcd0 link true /test unit
ci/prow/images 15abcd0 link true /test images
ci/prow/e2e-aws-parallel 15abcd0 link true /test e2e-aws-parallel
ci/prow/e2e-aws-serial 15abcd0 link true /test e2e-aws-serial
ci/prow/e2e-rosa 15abcd0 link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant