Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu2404] Fix tests of rule grub2_password #13007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alanmcanonical
Copy link
Contributor

Description:

  • Call set_grub_uefi_root to override the grub path in tests

Rationale:

  • The grub2_boot_path defined by Ubuntu is /boot/grub, we need to override the default one in tests

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 10, 2025
Copy link

openshift-ci bot commented Feb 10, 2025

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alanmcanonical
Copy link
Contributor Author

@dodys Please have a look.

Copy link

codeclimate bot commented Feb 10, 2025

Code Climate has analyzed commit 5b7e80d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@dodys dodys requested a review from a team February 10, 2025 12:51
@dodys dodys self-assigned this Feb 10, 2025
@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Feb 10, 2025
@dodys dodys added this to the 0.1.77 milestone Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants