-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deployment slot settings #862
Draft
nargiz
wants to merge
107
commits into
CompositionalIT:master
Choose a base branch
from
nargiz:compItMain
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
f1ae6f1
Add support for ip-restrictions for webApp/Functions.
viktorvan b78a545
allow slot_settings
nargiz f529e22
update slotSettingNames to be set
nargiz 849db95
Add support for multiple custom domains
r30e 106596d
Use domainName as certificate name
r30e de2b2e8
update docs + release notes
r30e edc6aae
Only turn on "auto" extension for Windows
isaacabraham 48626d1
Release notes
isaacabraham 8b9f7d9
Merge remote-tracking branch 'origin/master' into fix-linux-extension
isaacabraham de2fb64
Expanded description of custom_domain operator
r30e 3a882b7
Merge pull request #867 from CompositionalIT/fix-linux-extension
isaacabraham 7c8fcfc
Fix host name binding error when deploying multiple custom domains
6c136c2
Add support for custom docker port for web apps
stevebelskie aa9c093
Update web app documentation for docker_port
stevebelskie 47f8b38
Fix typo in App Setting (WEBSITE_PORT -> WEBSITES_PORT)
stevebelskie 8518bb5
Make connection_string and connections_strings available for azure fu…
amine-mejaouel 87a72a1
Add connection string docs for Azure Functions
amine-mejaouel 934eaaf
ZoneRedundant for service plan
nargiz f9de8d4
more test cases for service plan
nargiz 5dab8e7
Tiny cleanup
isaacabraham 63673cd
Merge pull request #870 from stevebelskie/master
isaacabraham db67331
Fix release notes
isaacabraham 04d33a8
Merge branch 'master' of github.com:CompositionalIT/farmer into add-i…
ninjarobot 41864e0
Support for CIDR network blocks on WebApp IP address restrictions
ninjarobot 561d3b7
Appending webapp restriction rules to end of list
ninjarobot 31ff0ca
Update RELEASE_NOTES.md
ninjarobot c3515dc
Clean up 1.6.26 release notes entries.
ninjarobot e5e4e70
Merge branch 'master' into azurefunction-connectionstrings
ninjarobot 3d0f1eb
Moving to correct version in release notes
ninjarobot cf09dfd
Merge branch 'master' of github.com:CompositionalIT/farmer into add-i…
ninjarobot 774e2d4
Merge branch 'master' into comItZoneRedundant
nargiz 2168606
use FeatureFlag for ZoneRedundant
nargiz 04bc033
update docs
nargiz e5943be
Merge pull request #835 from viktorvan/add-iprestrictions
ninjarobot 672ca19
Merge branch 'master' into azurefunction-connectionstrings
ninjarobot f773c44
Merge pull request #874 from amine-mejaouel/azurefunction-connections…
ninjarobot d23098f
Update RELEASE_NOTES for version 1.6.27
ninjarobot 7b0610b
1.6.27 release updates
ninjarobot a619428
Bundle LICENSE and README in nuget
ninjarobot 97fec9a
Merged from master
r30e ec78c6a
Merge pull request #866 from codatio/multiple-custom-domains
ninjarobot 868787b
Cleanup release notes for 1.6.27 release
ninjarobot 07e5284
Re-applied changes following pull from remote farmer master.
michaelwade-c5 8403226
Removed un-intended change
michaelwade-c5 c676c74
Removed un-intended change 2
michaelwade-c5 1647db4
Merge branch 'master' into comItZoneRedundant
nargiz 5a8c297
Merge pull request #876 from nargiz/comItZoneRedundant
ninjarobot 6e80b44
1.6.28 release
ninjarobot c554b65
Allow adding an IP with CIDR as a string to a web app
theprash 696806e
Use --only-show-errors - fixes #884
forki 9afadfb
fix core and memory
tforkmann bbb7d87
add hint to turn on ressource provider
tforkmann 8c8b484
Merge pull request #885 from forki/master
isaacabraham 2de2c8b
Merge pull request #886 from tforkmann/fix-containerapp-script
isaacabraham dcd0910
Merge pull request #887 from tforkmann/hint-resource-provider
isaacabraham 004ef55
Merge pull request #880 from ninjarobot/nuget-updates
isaacabraham 0ae6dea
1.6.29 release
ninjarobot a06cae7
Added support for WebApp vnet integration
r30e 062fb5c
Added tests
r30e b60cc2a
docs
r30e ccc6404
merge
r30e 2099a5d
cleanup
r30e 1aa19ef
Merge branch 'master' into ip-cidr-as-string
theprash 3e2592b
IP with CIDR: Add test and release notes
theprash 5cb9a58
Merge pull request #883 from CompositionalIT/ip-cidr-as-string
isaacabraham 3bd6686
App Insights now supports Log Analytics
isaacabraham 4754169
add VM Priority and Spot Instance
bigjonroberts 8d2053b
update tests for vm prioirity
bigjonroberts 6fea7c3
add documentation for vm priority and spot instance
bigjonroberts de90ac8
add sample for vm spot instance
bigjonroberts c45f736
Update release notes to include VM Priority and Spot Instance
bigjonroberts 1363c91
update release notes to 1.6.31 correctly
bigjonroberts 540a71e
cleanup comments
bigjonroberts 019a1ee
Add docs & samples.
isaacabraham 522b3cf
Small rename
isaacabraham 9dcf395
Merge remote-tracking branch 'origin/master' into feature/871-connect…
michaelwade-c5 42c2da0
Merge pull request #872 from mike-wade/feature/871-connection-string-…
isaacabraham 78233b3
Merge branch 'master' into vm-spot-instance
bigjonroberts a9f32a4
Fix test
isaacabraham 6578a0f
rename route_via_vnet -> vnet
r30e 6407710
Added validation
r30e 9fce32a
merged from master
r30e f9d8cd8
Updated release notes
r30e 77c2b5b
Update release notes and simplify tests.
isaacabraham 68a0fc1
Merge remote-tracking branch 'origin/master' into ai-workspaces
isaacabraham 7e281ce
Merge pull request #895 from CompositionalIT/ai-workspaces
isaacabraham d8cf05e
Merge branch 'master' into vm-spot-instance
bigjonroberts 9058d23
only allow one spot_instance or prioirity setting in VM
bigjonroberts cef4e04
correct some text on tests
bigjonroberts c9bc1c8
Add docs about what spot_instance actually does.
bigjonroberts c680a99
Update release notes changes to match tag on PR
bigjonroberts 19a03d0
Merge pull request #894 from bigjonroberts/vm-spot-instance
ninjarobot bcdf853
1.6.30 release
ninjarobot 7917662
update to resemble to vm builder instead of AKS builder
r30e 65b614c
merge
r30e b012a44
- update docs
r30e fd24ceb
Add validation for functions
r30e 3ac3498
AzureFirewall supports AvailabilityZones
e8ae29e
Release notes
5f3ada6
Fix test failure due to increased validation
r30e 5e34581
Adds JSON selection test for zonal AzFirewall
ninjarobot bf094e5
Merge pull request #888 from codatio/vnet-integration
ninjarobot 5737fc1
fix resource id for resource group config
6a4233d
Merge branch 'master' into ersoler/multiaz-firewall
ericsoler1 1d4eeb6
Merge pull request #900 from ericsoler1/ersoler/multiaz-firewall
ninjarobot a2eed20
merge with latest
nargiz a2bce2c
improvements for slot settings
nargiz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#r @"nuget:Farmer" | ||
|
||
open Farmer | ||
open Farmer.Builders | ||
|
||
let workspace = logAnalytics { | ||
name "loganalytics-workspace" | ||
} | ||
|
||
let myAppInsights = appInsights { | ||
name "appInsights" | ||
log_analytics_workspace workspace | ||
} | ||
|
||
let myFunctions = functions { | ||
name "functions-app" | ||
link_to_app_insights myAppInsights.Name | ||
} | ||
|
||
let template = arm { | ||
location Location.NorthEurope | ||
add_resources [ workspace; myAppInsights; myFunctions ] | ||
} | ||
|
||
template | ||
|> Deploy.execute "deleteme" Deploy.NoParameters |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
#r "nuget:Farmer" | ||
|
||
open Farmer | ||
open Farmer.Builders | ||
open Farmer.Vm | ||
|
||
let myVm = vm { | ||
name "isaacsVM" | ||
username "isaac" | ||
spot_instance Deallocate | ||
vm_size Standard_A2 | ||
operating_system WindowsServer_2012Datacenter | ||
os_disk 128 StandardSSD_LRS | ||
add_ssd_disk 128 | ||
add_slow_disk 512 | ||
diagnostics_support | ||
system_identity | ||
} | ||
|
||
let deployment = arm { | ||
location Location.NorthEurope | ||
add_resource myVm | ||
} | ||
|
||
deployment | ||
|> Deploy.execute "my-resource-group-name" Deploy.NoParameters |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,19 @@ | ||
[<AutoOpen>] | ||
module Farmer.Aliases | ||
|
||
[<AutoOpen>] | ||
module BuilderExtensions = | ||
open Farmer.Builders | ||
open Farmer.Arm.Network | ||
type IPrivateEndpoints<'TConfig> with | ||
member this.AddPrivateEndpoint(state:'TConfig, subnetId:LinkedResource) = this.AddPrivateEndpoint (state, SubnetReference.create subnetId) | ||
member this.AddPrivateEndpoint(state:'TConfig, subnet:SubnetConfig) = this.AddPrivateEndpoint (state, SubnetReference.create subnet) | ||
member this.AddPrivateEndpoint(state, (subnetRef:LinkedResource,epName)) = this.AddPrivateEndpoint (state, (SubnetReference.create subnetRef, epName)) | ||
member this.AddPrivateEndpoint(state:'TConfig, (vnetRef, subnetName):LinkedResource * ResourceName) = this.AddPrivateEndpoint (state, SubnetReference.create (vnetRef,subnetName)) | ||
member this.AddPrivateEndpoint(state, (vnetRef,subnetName,epName):LinkedResource * ResourceName * string) = this.AddPrivateEndpoint (state, ((SubnetReference.create (vnetRef, subnetName)), epName)) | ||
member this.AddPrivateEndpoint(state:'TConfig, (vnet, subnetName):VirtualNetworkConfig * ResourceName) = this.AddPrivateEndpoint (state, SubnetReference.create (vnet,subnetName)) | ||
|
||
member this.AddPrivateEndpoints(state:'TConfig, subnetIds:LinkedResource list) = this.AddPrivateEndpoints (state, subnetIds |> List.map SubnetReference.create |> Set) | ||
member this.AddPrivateEndpoints(state:'TConfig, subnets:SubnetConfig list) = this.AddPrivateEndpoints (state, subnets |> List.map SubnetReference.create |> Set) | ||
|
||
let arm = Farmer.Builders.ResourceGroup.DeploymentBuilder () |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether it's possible to piggy back on the existing
setting
keywords? Also, there's also thesecret_setting
keyword for adding secure settings - this should probably be migrated as well if we keep with separate keywords.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this really differ from including config when adding a slot with
add_slot
and using the SlotBuilder withaddSlot
? I see this PR addsslotconfignames
when you add these - is the purpose of this just for sticky config?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make settings sticky, their names should be specified in webapp(
sites
) child resource,slotconfignames
. We usually add settings in webapp, so the idea was to haveslot_setting
which adds the setting and creates child resourceslotconfignames
.The alternative solution was something similar to this:
Where
slot_setting_names
was only marking the settings as sticky by addingslotconfignames
, But we thought the current solution withslot_setting
will make things clearer.