fix infinite instant transition loop #5287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BrianMarre
commented
Feb 19, 2025
•
BrianMarre
commented
- requires PR refactor field energy calculation #5284 to be merged first
- requires PR refactor atomic physics stage #5285 to be merged first
- requires PR guard against rate cache equal to zero #5286 to be merged first
- must be rebased to dev
switches the FLYonPIC(AtomicPhysis) stage's applyIPDIonization and applyInstantTransition sub-loops from a do-while loop to a while loop to improve readabiltiy and consistency. ci: picongpu
fixes a division by zero in the choose transition kernels if the rate cache entry for the state happens to be zero. ci: picongpu
implements a guard that ensure that the ADK rate calculation will return 0 if the local available field energy is lower than the single ion ionization energy
mask transitions whose field energy requirements for the entire macro ion are larger than the cells field energy.
ci: picongpu
BrianMarre
force-pushed
the
topic-fixInfiniteInstantTransitionLoop
branch
from
0ea82b9 to
074eecd
Compare
ikbuibui
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.