Merge pull request #81 from ikbuibui/pessimizing_moves

Remove pessimizing moves
ComputationalRadiationPhysics · Jul 24, 2024 · 8be11e9 · 8be11e9
2 parents 94c28d3 + 30945ed
commit 8be11e9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/redGrapes/redGrapes.hpp b/redGrapes/redGrapes.hpp
@@ -159,7 +159,7 @@ namespace redGrapes
             // construct task in-place
             new(task) FunTask<Impl, RGTask>(worker_id, *scheduler_map[TSchedTag{}]);
 
-            return std::move(TaskBuilder<RGTask, Callable, Args...>(task, std::move(f), std::forward<Args>(args)...));
+            return TaskBuilder<RGTask, Callable, Args...>(task, std::forward<Callable>(f), std::forward<Args>(args)...);
         }
 
         template<typename Callable, typename... Args>

diff --git a/redGrapes/task/task_builder.hpp b/redGrapes/task/task_builder.hpp
@@ -103,7 +103,7 @@ namespace redGrapes
             space->submit(t);
             t->scheduler_p->emplace_task(*t);
 
-            return std::move(Future<Result, TTask>(*t));
+            return Future<Result, TTask>(*t);
         }
 
         auto get()

diff --git a/redGrapes/util/bind_args.hpp b/redGrapes/util/bind_args.hpp
@@ -13,6 +13,6 @@ struct BindArgs
 {
     inline auto operator()(Callable&& f, Args&&... args)
     {
-        return std::move([f = std::move(f), args...]() mutable { return f(std::forward<Args>(args)...); });
+        return [f = std::move(f), args...]() mutable { return f(std::forward<Args>(args)...); };
     }
 };