Fix child parent dependency #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocoderHPC
approved these changes
May 16, 2024
psychocoderHPC
merged commit 8cb58e5
into
ComputationalRadiationPhysics:dev
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where a parent task is destroyed before
init_graphis called on child tasks.Before this PR
init_graphwas adding the dependency from the child task to the post event of the parent. Butinit_graphis only called when the child task is actually processed to be put into the ready queue. This leads to a situation where the parent task can be destroyed and its post event will be notified while the child tasks are still in the emplacement queue.Moved adding the dependency to the parent task from the child task to
emplace_task.This moves some work from scheduling to emplacement.