baton databricks v0 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreer
reviewed
Dec 18, 2023
- use logger from context instead of `fmt` - prepare credentials in config for workspace API - refactor the flow of config validation - account id has be present at all times - currently only Basic or SCIM are supported - comment out handling workspace API configuration for now
- lists only the top account resource based on specified account id - acts as a parent resource to all other resources - mimics API design - implements granting of marketplace.admin role - we can obtain who has marketplace.admin role only when we look for rule sets scoped to whole account
- lists all existing groups under account - adds various entitlements - membership entitlement - permission entitlement - granting assignable roles (group manager) to other identities - workspace scoped entitlements (for example `allow-cluster-create`) - todo: implement grants for workspace scoped entitlements
- lists all existing ServicePrincipals under account - adds various entitlements - role entitlements - granting itself roles - permission entitlement - granting assignable roles (group manager) to other identities - workspace scoped entitlements (for example `allow-cluster-create`) - granting itself a permissions
- lists all existing Workspaces under account - todo: entitlements & grants for workspace API
- lists static roles and entitlements that identities in Databricks can have - granting process is complex due to API design - no way to filter by role - due to adding this resource, we remove cyclic entitlements and grants on other identities (users, groups, servicePrincipals) - this involves roles like account_admin or workspace specific entitlements like workspace_access or databricks_sql_access
- add helpers - add resource types - polish and optimize
- add helpers for - path and query parameters - authentication - resolving the URL paths - add models and helper methods
- SCIM token have only restricted capabilities, it can't list roles or rule sets, which are very important for connector
- with client_credentials grant type - refactored how http client is obtained
ggreer
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/ConductorOne/baton-project-status/issues/70.
Includes integrated Users, Groups, ServicePrincipals and Roles with their entitlements and grants.