fix azure databricks + docs #15
Conversation
pkg/databricks/client.go
Outdated
|
|
||
| func GetAccountHostname(cfg *viper.Viper) string { | ||
| if cfg.GetString(config.AccountHostnameField.FieldName) == "" { | ||
| return "accounts." + GetHostname(cfg) |
There was a problem hiding this comment.
I don't think this will work for Azure or GCP, as the hostname provided will be something like 8757561887652360.0.gcp.databricks.com or adb-5555555555555555.19.azuredatabricks.net, but the account hostnames for those need to be accounts.gcp.databricks.com and accounts.azuredatabricks.net respectively. Prepending "accounts" to the hostnames will result in accounts.8757561887652360.0.gcp.databricks.com and accounts.adb-5555555555555555.19.azuredatabricks.net, which isn't correct.
There was a problem hiding this comment.
@ggreer Isn't that solved by just using account-hostname ?
There was a problem hiding this comment.
Yes but we should change the behavior to detect GCP and Azure hostnames and return correct account hostnames for them.
No description provided.