Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate grant expansion entitlement IDs without using resource cache. #19

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

ggreer
Copy link
Contributor

@ggreer ggreer commented Feb 19, 2025

This fixes an error with Azure Databricks and improves performance.

This fixes an error with Azure Databricks and improves performance.
Copy link
Contributor

@btipling btipling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the bug? I can't tell from the diff

@ggreer
Copy link
Contributor Author

ggreer commented Feb 19, 2025

The cache wasn't always fully populated, and we'd fail to fetch the group because we're generating the wrong workspace URL for Azure Databricks instances: https://learn.microsoft.com/en-us/azure/databricks/workspace/workspace-details

But we don't need to fetch the group to figure out the entitlement ID to add the grant expansion annotation. We just need to know the group ID and the parent resource ID (since groups can belong to accounts or workspaces).

@ggreer ggreer merged commit b06c8ac into main Feb 19, 2025
3 checks passed
@ggreer ggreer deleted the ggreer/fix-azure-databricks-groups branch February 19, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants