Morgabra/add decrypt #108
Merged
Morgabra/add decrypt #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented argument to check a specific app instead of all apps, which will still be checked if no args are passed * Updated validating command arguments and return message * Swapped fmt.printf to pterm.printf * Update cmd/cone/decrypt.go Co-authored-by: Logan Saso <[email protected]> * Update cmd/cone/decrypt.go Co-authored-by: Logan Saso <[email protected]> --------- Co-authored-by: Logan Saso <[email protected]>
mstanbCO
reviewed
Oct 31, 2024
|
|
||
| // appUsers := make([]shared.AppUser, 0) | ||
|
|
||
| return resp.AppUserServiceListCredentialsResponse.List, nil |
There was a problem hiding this comment.
Probably should check that resp.appuserServiceListCredentialsResponse is not nil before using the list.
mstanbCO
reviewed
Oct 31, 2024
pkg/client/appuser.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| // appUsers := make([]shared.AppUser, 0) |
There was a problem hiding this comment.
remove the comments in this function?
mstanbCO
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.