fix: non-native zero IsZero edge case #1413
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the compiler can deduce that non-native element is constant zero, then we represent it on zero limbs. However in
IsZero
method we initialized the accumulator from first limb without range checking. This PR adds fast path for constant zero.Fixes #1412
Type of change
How has this been tested?
IsZeroCircuit
test to include the regressionChecklist:
golangci-lint
does not output errors locally