Skip to content

Commit

Permalink
[Fix] CI warnings (#590)
Browse files Browse the repository at this point in the history
* update actions/cache to 4.2.0 as per deprecation warning

* checkout before setup-go in prover-testing.yml

* point setup-go to prover/go.sum

* empty commit to rerun prover test after go action cache

* fix cache hit error in prover-test workflow

* apply golang caching changes to run-smc-tests

* fix bad change to cache-docker-images
  • Loading branch information
kyzooghost authored Jan 23, 2025
1 parent aeac0e0 commit 99f1338
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 17 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cache-docker-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
done
- name: Cache common docker images
continue-on-error: true
uses: actions/cache/save@v4.0.2
uses: actions/cache/save@v4.2.0
with:
path: ~/docker-images
key: cached-images
2 changes: 1 addition & 1 deletion .github/workflows/coordinator-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
uses: gradle/actions/setup-gradle@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 #v4.2.1
- name: Restore cached images
id: restore-cached-images
uses: actions/cache/restore@v4.0.2
uses: actions/cache/restore@v4.2.0
with:
path: ~/docker-images
key: cached-images
Expand Down
22 changes: 12 additions & 10 deletions .github/workflows/prover-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,19 @@ jobs:
runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-med
name: Prover static check
steps:
- name: install Go
uses: actions/setup-go@v5
with:
go-version: 1.23.x
- name: checkout code
uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: actions/cache@v4
- name: install Go
uses: actions/setup-go@v5
with:
go-version: 1.23.x
cache-dependency-path: |
prover/go.sum
- uses: actions/[email protected]
with:
path: |
~/go/pkg/mod
~/.cache/go-build
~/Library/Caches/go-build
%LocalAppData%\go-build
Expand Down Expand Up @@ -59,16 +60,17 @@ jobs:
needs:
- staticcheck
steps:
- name: checkout code
uses: actions/checkout@v4
- name: install Go
uses: actions/setup-go@v5
with:
go-version: ${{ matrix.go-version }}
- name: checkout code
uses: actions/checkout@v4
- uses: actions/cache@v4
cache-dependency-path: |
prover/go.sum
- uses: actions/cache@v4.2.0
with:
path: |
~/go/pkg/mod
~/.cache/go-build
~/Library/Caches/go-build
%LocalAppData%\go-build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reuse-run-e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:
chmod -R a+w tmp/local/traces/v2/conflated
- name: Restore cached images
id: restore-cached-images
uses: actions/cache/restore@v4.0.2
uses: actions/cache/restore@v4.2.0
with:
path: ~/docker-images
key: cached-images
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-smc-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ jobs:
uses: actions/setup-go@v5
with:
go-version: 1.23.x
cache: false
cache-dependency-path: |
prover/go.sum
- uses: actions/cache@v4
- uses: actions/cache@v4.2.0
with:
path: |
~/go/pkg/mod
~/.cache/go-build
~/Library/Caches/go-build
%LocalAppData%\go-build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/staterecovery-testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
uses: gradle/actions/setup-gradle@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 #v4.2.1
- name: Restore cached images
id: restore-cached-images
uses: actions/cache/restore@v4.0.2
uses: actions/cache/restore@v4.2.0
with:
path: ~/docker-images
key: cached-images
Expand Down

0 comments on commit 99f1338

Please sign in to comment.