Docker secrets required false

Consensys · Oct 18, 2024 · d2fdd18 · d2fdd18
1 parent e4149a8
commit d2fdd18
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/.github/actions/check-image-tags-exist/action.yml b/.github/actions/check-image-tags-exist/action.yml
@@ -8,12 +8,6 @@ inputs:
   image_name:
     description: 'The name of the image to check'
     required: true
-  docker_username:
-    description: 'The username to login to Docker Hub'
-    required: true
-  docker_password:
-    description: 'The password to login to Docker Hub'
-    required: true
 outputs:
   last_commit_tag_exists:
     description: 'Whether the last commit image tag exists'

diff --git a/.github/workflows/reuse-check-images-tags-and-push.yml b/.github/workflows/reuse-check-images-tags-and-push.yml
@@ -34,9 +34,9 @@ on:
         value: ${{ jobs.image_tag_push.outputs.image_tagged_traces_api_facade }}
     secrets:
       DOCKERHUB_USERNAME:
-        required: true
+        required: false
       DOCKERHUB_TOKEN:
-        required: true
+        required: false
 
 concurrency:
   group: check-images-tags-and-push-${{ github.workflow }}-${{ github.ref }}
@@ -61,13 +61,11 @@ jobs:
 
       - name: Check image tags exist for coordinator
         uses: ./.github/actions/check-image-tags-exist
-        if: ${{ inputs.coordinator_changed != 'false' }}
+        if: ${{ inputs.coordinator_changed == 'false' }}
         id: check_image_tags_exist_coordinator
         with:
           last_commit_tag: ${{ inputs.last_commit_tag }}
           image_name: consensys/linea-coordinator
-          docker_username: ${{ secrets.DOCKERHUB_USERNAME }}
-          docker_password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Check image tags exist for postman
         uses: ./.github/actions/check-image-tags-exist
@@ -76,8 +74,6 @@ jobs:
         with:
           last_commit_tag: ${{ inputs.last_commit_tag }}
           image_name: consensys/linea-postman
-          docker_username: ${{ secrets.DOCKERHUB_USERNAME }}
-          docker_password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Check image tags exist for prover
         uses: ./.github/actions/check-image-tags-exist
@@ -86,8 +82,6 @@ jobs:
         with:
           last_commit_tag: ${{ inputs.last_commit_tag }}
           image_name: consensys/linea-prover
-          docker_username: ${{ secrets.DOCKERHUB_USERNAME }}
-          docker_password: ${{ secrets.DOCKERHUB_TOKEN }}
 
       - name: Check image tags exist for traces-api-facade
         uses: ./.github/actions/check-image-tags-exist
@@ -96,11 +90,10 @@ jobs:
         with:
           last_commit_tag: ${{ inputs.last_commit_tag }}
           image_name: consensys/linea-traces-api-facade
-          docker_username: ${{ secrets.DOCKERHUB_USERNAME }}
-          docker_password: ${{ secrets.DOCKERHUB_TOKEN }}
 
   image_tag_push:
     runs-on: [self-hosted, ubuntu-20.04, X64, small]
+    if: ${{ github.ref == 'refs/heads/main' }}
     name: Tag and push images
     needs: [ check_image_tags_exist ]
     outputs: