smt: minor improvements #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
Signed-off-by: Ignacio Hagopian <[email protected]>
jsign
commented
Dec 2, 2024
AlexandreBelling
approved these changes
Dec 3, 2024
AlexandreBelling
added
Prover
AlexandreBelling
requested review from
gusiri,
bogdanbear,
Soleimani193 and
arijitdutta67
AlexandreBelling
requested changes
Dec 3, 2024
Signed-off-by: Ignacio Hagopian <[email protected]>
AlexandreBelling
approved these changes
Dec 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
============================================
- Coverage 68.18% 68.17% -0.01%
Complexity 1129 1129
============================================
Files 320 320
Lines 12858 12858
Branches 1292 1292
============================================
- Hits 8767 8766 -1
- Misses 3560 3561 +1
Partials 531 531
*This pull request uses carry forward flags. Click here to find out more. |
|
|
|
Just signed the CLA. |
|
PR has had no activity for 30 days. What is blocking it? Is there anything you can do to help move it forward? Without action it will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into the
smtpackage, and I found some nits while reading.