Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover/Codehash Non Power of Two Column Size #618

Conversation

arijitdutta67
Copy link
Contributor

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@arijitdutta67 arijitdutta67 temporarily deployed to docker-build-and-e2e January 29, 2025 11:01 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (b1a7319) to head (d369c96).

Additional details and impacted files
@@                  Coverage Diff                   @@
##             prover/beta-v1.2     #618      +/-   ##
======================================================
- Coverage               70.92%   68.89%   -2.04%     
  Complexity               1186     1186              
======================================================
  Files                     359      327      -32     
  Lines                   14076    13127     -949     
  Branches                 1545     1317     -228     
======================================================
- Hits                     9984     9044     -940     
+ Misses                   3543     3534       -9     
  Partials                  549      549              
Flag Coverage Δ *Carryforward flag
hardhat 98.74% <ø> (-0.16%) ⬇️
kotlin 66.54% <ø> (ø) Carriedforward from 96f3a8c

*This pull request uses carry forward flags. Click here to find out more.

see 32 files with indirect coverage changes

@gusiri gusiri marked this pull request as ready for review January 29, 2025 11:46
@gusiri gusiri merged commit 4cf988c into prover/beta-v1.2 Jan 29, 2025
14 of 16 checks passed
@gusiri gusiri deleted the prover/beta-v1.2-codehash-non-power-of-two-column-size-fix branch January 29, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants