Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: fix BlockCreationMonitorTest flacky test #624

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

jpnovais
Copy link
Collaborator

@jpnovais jpnovais commented Jan 29, 2025

This PR implements issue(s) #612

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais requested a review from Filter94 January 29, 2025 16:10
Filter94
Filter94 previously approved these changes Jan 29, 2025
@jpnovais jpnovais merged commit 8c7c9eb into main Jan 29, 2025
22 checks passed
@jpnovais jpnovais deleted the fix-flacky-test branch January 29, 2025 16:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (c819e31) to head (7a38838).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #624      +/-   ##
============================================
- Coverage     68.74%   68.71%   -0.04%     
+ Complexity     1186     1185       -1     
============================================
  Files           324      324              
  Lines         13190    13190              
  Branches       1317     1317              
============================================
- Hits           9068     9064       -4     
- Misses         3572     3573       +1     
- Partials        550      553       +3     
Flag Coverage Δ *Carryforward flag
hardhat 99.05% <ø> (ø) Carriedforward from c819e31
kotlin 66.36% <ø> (-0.04%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants