Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve null safety in RequestHandlersV1 #652

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

  • Replace unsafe null assertions (!!) with proper null checks
  • Add explicit null validation for transaction hash parameter
  • Add descriptive error messages for null cases
  • Improve error handling in parameter parsing

These changes make the code more robust by preventing potential NullPointerExceptions and providing clearer error messages when invalid data is provided.

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

- Replace unsafe null assertions (!!) with proper null checks
- Add explicit null validation for transaction hash parameter
- Add descriptive error messages for null cases
- Improve error handling in parameter parsing

These changes make the code more robust by preventing potential NullPointerExceptions 
and providing clearer error messages when invalid data is provided.

Signed-off-by: VolodymyrBg <[email protected]>
Copy link

cla-assistant bot commented Feb 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant