-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metrics in GlobalBlobAwareConflationCalculator and move bri… #654
base: main
Are you sure you want to change the base?
feat: add metrics in GlobalBlobAwareConflationCalculator and move bri… #654
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
============================================
+ Coverage 68.38% 68.67% +0.29%
- Complexity 1185 1201 +16
============================================
Files 323 323
Lines 13131 13227 +96
Branches 1319 1330 +11
============================================
+ Hits 8979 9084 +105
+ Misses 3600 3589 -11
- Partials 552 554 +2
*This pull request uses carry forward flags. Click here to find out more.
|
1412aaf
to
40c25db
Compare
...in/kotlin/net/consensys/zkevm/coordinator/clients/prover/FileBasedExecutionProverClientV2.kt
Show resolved
Hide resolved
...in/net/consensys/zkevm/ethereum/coordination/proofcreation/ZkProofCreationCoordinatorImpl.kt
Outdated
Show resolved
Hide resolved
...in/net/consensys/zkevm/ethereum/coordination/proofcreation/ZkProofCreationCoordinatorImpl.kt
Outdated
Show resolved
Hide resolved
...in/net/consensys/zkevm/ethereum/coordination/proofcreation/ZkProofCreationCoordinatorImpl.kt
Outdated
Show resolved
Hide resolved
40c25db
to
644ca9c
Compare
644ca9c
to
c25c3f4
Compare
.../net/consensys/zkevm/ethereum/coordination/conflation/GlobalBlobAwareConflationCalculator.kt
Outdated
Show resolved
Hide resolved
.../net/consensys/zkevm/ethereum/coordination/conflation/GlobalBlobAwareConflationCalculator.kt
Outdated
Show resolved
Hide resolved
.../consensys/zkevm/ethereum/coordination/aggregation/ProofAggregationCoordinatorServiceTest.kt
Outdated
Show resolved
Hide resolved
@@ -86,7 +87,8 @@ class GlobalBlobAwareConflationCalculatorTest { | |||
calculator = GlobalBlobAwareConflationCalculator( | |||
conflationCalculator = globalCalculator, | |||
blobCalculator = calculatorByDataCompressed, | |||
batchesLimit = defaultBatchesLimit | |||
batchesLimit = defaultBatchesLimit, | |||
metricsFacade = mock<MetricsFacade>(defaultAnswer = Mockito.RETURNS_DEEP_STUBS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes here.
Also, we should add tests to check that the metrics are correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree to add tests for the metrics and would use mocks here for metricsFacade
and histogram instances to check the metric values passed to the histogram record
function
…dge logs and state root hash retrieval from execution prover client to coordinator
787148c
to
e67bbf9
Compare
…dge logs and state root hash retrieval from execution prover client to coordinator
This PR implements issue(s) #604
Checklist