AO-58 Add support for agent token in the helm chart #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gamingrobot
commented
Jan 24, 2025
•
gamingrobot
commented
- Adds new existingTokenSecret
- Adds new tokenValue
- Supports legacy auth values
gamingrobot
force-pushed
the
AO-58-helm-token-supprt
branch
from
91520be to
a4e1de3
Compare
andersonshatch
requested changes
Jan 31, 2025
| stringData: | ||
| token: >- | ||
| {{ required "The key clusterDefaults.tokenValue must be set if clusterDefaults.enabled is true and clusterDefaults.existingTokenSecret is not set" .Values.clusterDefaults.tokenValue }} | ||
| {{else if not .Values.clusterDefaults.existingSecret }} |
There was a problem hiding this comment.
Need to check that .Values.clusterDefaults.existingTokenSecret is unset here too.
Currently if you specify an existingTokenSecret only, this section is still reached, and then apiKeyValue is required.
gamingrobot
force-pushed
the
AO-58-helm-token-supprt
branch
from
a4e1de3 to
4cbd46d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.