Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve a logic to select whether SSH key or Username #2891

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

jeonghanlee
Copy link
Contributor

@jeonghanlee jeonghanlee commented Dec 12, 2023

@shroffk This is our try to improve the logic behind your mind, which we (@jeonghanlee and
@Sangil-Lee ) figured out. I think your mind is brilliant ;)

We tested the following both cases:

Username

In alarm_config_logger.properties,

remote.location=https://git_repo/...
use_ssh_keys = false
username = aaa
password = bbb

SSH Key

remote.location=git@git_repo/...
use_ssh_keys = true

In this case, we also rename .ssh folder, and saw SshException in a log. After reverting to .ssh, everything worked well.

Please let me know what you think.

@shroffk shroffk merged commit 46aaaec into ControlSystemStudio:master Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants