Improve a logic to select whether SSH key or Username #2891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shroffk This is our try to improve the logic behind your mind, which we (@jeonghanlee and
@Sangil-Lee ) figured out. I think your mind is brilliant ;)
We tested the following both cases:
Username
In
alarm_config_logger.properties
,SSH Key
In this case, we also rename
.ssh
folder, and sawSshException
in a log. After reverting to.ssh
, everything worked well.Please let me know what you think.