Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create ImplMtHelpers #290

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

jawoznia
Copy link
Collaborator

No description provided.

@jawoznia jawoznia requested a review from hashedone January 22, 2024 09:35
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (463257e) 80.98% compared to head (e0b89c8) 80.86%.
Report is 1 commits behind head on feat/generics_forwarding.

Files Patch % Lines
sylvia-derive/src/multitest.rs 91.39% 8 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/generics_forwarding     #290      +/-   ##
============================================================
- Coverage                     80.98%   80.86%   -0.13%     
============================================================
  Files                            28       28              
  Lines                          1993     1970      -23     
============================================================
- Hits                           1614     1593      -21     
+ Misses                          379      377       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kulikthebird kulikthebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about using Multitest in Sylvia. There's only one brief comment and other than that it seems we can go forward.

@jawoznia jawoznia force-pushed the remove_mt_trait_utils_generation branch from f63fab1 to 0fb29a9 Compare January 31, 2024 15:30
Base automatically changed from remove_mt_trait_utils_generation to feat/generics_forwarding January 31, 2024 15:46
@jawoznia jawoznia merged commit 8d819e6 into feat/generics_forwarding Jan 31, 2024
6 of 7 checks passed
@jawoznia jawoznia deleted the add_impl_mt_helper branch January 31, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants