Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep compatibility for context key #2077

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

pinosu
Copy link
Contributor

@pinosu pinosu commented Dec 30, 2024

See #2075

@pinosu pinosu requested a review from chipshort December 30, 2024 17:05
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.99%. Comparing base (aafd0e0) to head (25fa6ea).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2077      +/-   ##
==========================================
+ Coverage   42.97%   42.99%   +0.01%     
==========================================
  Files          85       85              
  Lines       11601    11601              
==========================================
+ Hits         4986     4988       +2     
+ Misses       6167     6166       -1     
+ Partials      448      447       -1     
Files with missing lines Coverage Δ
x/wasm/types/context.go 13.88% <ø> (ø)

... and 1 file with indirect coverage changes

@chipshort
Copy link
Collaborator

I didn't know this is something we should keep stable across versions. Does anyone depend on the exact values?

@pinosu
Copy link
Contributor Author

pinosu commented Jan 7, 2025

I didn't know this is something we should keep stable across versions. Does anyone depend on the exact values?

Context keys are set as an enumeration so I think it is good to not mix keys that have different scopes but rather create a new one for new scope.
This topic anyway will be irrelevant in future releases because from cosmos-sdk v0.52 onwards the sdk context is deprecated and also this storage.

Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, then let's keep them stable

@pinosu pinosu merged commit ef8e57b into main Jan 8, 2025
19 checks passed
@pinosu pinosu deleted the compatibility_context_key branch January 8, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants