Eureka port binding #2123
Eureka port binding #2123
Conversation
| @@ -544,6 +564,16 @@ func (k Keeper) migrate( | |||
| } | |||
| k.mustStoreContractInfo(ctx, contractAddress, contractInfo) | |||
|
|
|||
| // Should we bind the port in some special way for Eureka? | |||
There was a problem hiding this comment.
My understanding is that we need to call this. And I guess also need to make sure that this is called for all registered ports every time the chain starts? So, we might have to keep track of contract ports in storage unless there already is such a mechanism in ibc-go.
There was a problem hiding this comment.
I guess this would work providing we would got the list of contracts.
Let's discuss it offline.
There was a problem hiding this comment.
We discovered yesterday, that the port binding is not supported anymore in ibc-go
There was a problem hiding this comment.
I think there's a difference here between IBC v1 and Eureka. In v1, we don't need to do port binding anymore because ibc-go detects the "wasm" prefix and routes it to us based on that, but I don't know if the same works for Eureka.
There was a problem hiding this comment.
Yes, it seems that in Eureka we have to use this method: https://github.com/cosmos/ibc-go/blob/3e6d5f597fc498a949011ca1d9e835ef6c163813/modules/core/api/router.go#L24. We have to change our approach a little bit, because so far wasmd added routes in a NewWasmApp method. With Eureka we have to bind a contract address with a new Eureka IBCModule. I started implementation of this module here: #2124
Co-authored-by: Christoph Otter <[email protected]>
No description provided.