Refacto: Policy & keys data structure #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
November 9, 2023 14:04
tbrezot
reviewed
Nov 24, 2023
ThibsG
reviewed
Nov 30, 2023
* test: demonstrate useless key creation problems due to rotation * feat: add `VersionedMap` to be used to store MPK partitions versions * feat: implement usual functions for `RevisionMap` * feat: use `RevisionMap` to store `MasterPublicKey` subkeys * feat: use `RevisionMap` to store `MasterSecretKey` subkeys * feat: remove old `rotate` function from Policy * feat: remove old `VersionedHashmap` data struct * feat: add `RevisionVec` to store USK subkeys * feat: replace `VersionedVec` with `RevisionVec` in USK implementation * feat: rewrite usk refresh using new data structs * feat: add back `keep_old_rights`option to usk refresh method * feat: store MPK subkeys in regular HashMap * refacto: begin rewriting of master keys `update` function * refacto: rewrite master keys update using exhaustive pattern matching * refacto: improve user subkeys encapsulation * refacto: simplify ways to insert new chains in `RevisionVec` * feat: add `keep_old_subkeys` parameter for rekey operation * test: add tests and docstring for `RevisionMap` and `RevisionVec` * test: update rekey tests * docs: add usage warning for policy edition methods * test: update user key refresh test * fix: update runme example * refacto: clean iter and map in `RevisionMap` * feat: apply suggestions from code review Co-authored-by: Théophile BRÉZOT <[email protected]> * refacto: apply suggestions on `RevisionVec` and `RevisionMap` * docs: update comments and params name * feat: add dedicated `prune_master_keys` to remove old subkeys * refacto: remove deadcode * refacto: apply review suggestions * refacto: simplify first part of usk refresh * refacto: factor out logic from user key `refresh` * refacto: use peekable iter `next_if` method instead of `take_while` * refacto: remove special case for refresh with `keep_old_rights` * refacto: clean RevisionList cursor `skip_while` function * refacto: clean `RevisionList` cursor structure * refacto: rename Revision Map `get_current_element` to `get_latest` * refacto: apply suggestions to remove clone --------- Co-authored-by: Théophile BRÉZOT <[email protected]>
ackRow
force-pushed
the
feat/optimize_data_struct
branch
from
8e9928f to
2536a50
Compare
tbrezot
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.