Fix: use mem::take instead of RefCell to refresh UserSecretKey
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrezot
approved these changes
Jan 19, 2024
tbrezot
pushed a commit
that referenced
this pull request
Jan 26, 2024
…124) feat: add partial coordinates fix: cargo test --all-features - remove benches (see `fix/benches`) - remove `serialization` feature to fix tests that depend on it. fix: access policy parsing Simplify parsing code and correct parsing errors. Notice that now, empty access policies can be parsed. Parsing should be more efficient too, but we lack benchmarks for that. The only downside is that allowing '&' or '|' inside attributes is painful to write. I consider it an acceptable limitation to the expressivness allowed by the parsing operation. This is a breaking change though. All "Department::R&D" attributes have been renamed into "Department::RD". fix: access policy parsing rename!: rename `from_boolean_expression` into `parse` fix: neats
tbrezot
pushed a commit
that referenced
this pull request
Mar 18, 2024
…124) feat: add partial coordinates fix: cargo test --all-features - remove benches (see `fix/benches`) - remove `serialization` feature to fix tests that depend on it. fix: access policy parsing Simplify parsing code and correct parsing errors. Notice that now, empty access policies can be parsed. Parsing should be more efficient too, but we lack benchmarks for that. The only downside is that allowing '&' or '|' inside attributes is painful to write. I consider it an acceptable limitation to the expressivness allowed by the parsing operation. This is a breaking change though. All "Department::R&D" attributes have been renamed into "Department::RD". fix: access policy parsing rename!: rename `from_boolean_expression` into `parse` fix: neats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.