Support scrolling properly #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrolling wasnt supported in the MouseManager and the PS2 implementation didnt implement it properly anyways
jp2masa
reviewed
Dec 30, 2023
quajak
reviewed
Dec 31, 2023
quajak
reviewed
Dec 31, 2023
Co-authored-by: Quajak <[email protected]>
Co-authored-by: Quajak <[email protected]>
quajak
requested changes
Jan 1, 2024
source/Cosmos.HAL2/PS2Mouse.cs
Outdated
| { | ||
| mouseByte[3] = IOPort.Read8(Core.IOGroup.PS2Controller.Data); | ||
| mouseCycle++; | ||
| } | ||
|
|
||
| // TODO: move conditions to the if statement when stack corruption detection | ||
| // works better for complex conditions | ||
| var xTest1 = mouseCycle == 2 && !HasScrollWheel; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrolling wasnt supported in the MouseManager and the PS/2 implementation didnt implement it properly either