Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Tidy some imports and tests #4032

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor: Tidy some imports and tests #4032

wants to merge 4 commits into from

Commits on Nov 15, 2024

  1. Add functions to safely convert unstructured types 

    The default unstructured converter does not complain if you try to
convert a list to an object or vice versa.
    @cbandy
    cbandy committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b3c4588 View commit details
    Browse the repository at this point in the history

  2. Run upgrade tests in isolated namespaces

    @cbandy
    cbandy committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c5cf734 View commit details
    Browse the repository at this point in the history

  3. Remove github.com/pkg/errors from tests 

    Tests already report the line on which an assert fails, and the
standard "errors" packages unwraps errors.
    @cbandy
    cbandy committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5545bd7 View commit details
    Browse the repository at this point in the history

  4. Load VolumeSnapshot CRDs from the client Go module during tests 

    We only use these CRD files in Go tests, and Go has already downloaded
them as part of the module we import for serializing API objects.
    @cbandy
    cbandy committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    851f55c View commit details
    Browse the repository at this point in the history