test & lint

Cryoris · Feb 11, 2025 · 00867cb · 00867cb
1 parent a90b61d
commit 00867cb
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 12 deletions.
diff --git a/qiskit/circuit/library/arithmetic/piecewise_chebyshev.py b/qiskit/circuit/library/arithmetic/piecewise_chebyshev.py
@@ -419,6 +419,15 @@ def __init__(
 
     @property
     def polynomials(self):
+        """The polynomials for the piecewise approximation.
+
+        Returns:
+            The polynomials for the piecewise approximation.
+
+        Raises:
+            TypeError: If the input function is not in the correct format.
+        """
+
         # note this must be the private attribute since we handle missing breakpoints at
         # 0 and 2 ^ num_qubits here (e.g. if the function we approximate is not defined at 0
         # and the user takes that into account we just add an identity)

diff --git a/qiskit/synthesis/arithmetic/comparators/compare_2s.py b/qiskit/synthesis/arithmetic/comparators/compare_2s.py
@@ -13,8 +13,8 @@
 """Integer comparator based on 2s complement."""
 
 import math
-from qiskit.circuit import QuantumCircuit
-from qiskit.circuit.library import OR
+from qiskit.circuit.quantumcircuit import QuantumCircuit
+from qiskit.circuit.library.boolean_logic.quantum_or import OrGate
 
 
 def synth_integer_comparator_2s(
@@ -40,18 +40,14 @@ def synth_integer_comparator_2s(
                         circuit.cx(qr_state[i], qr_ancilla[i])
                 elif i < num_state_qubits - 1:
                     if twos[i] == 1:
-                        circuit.compose(
-                            OR(2), [qr_state[i], qr_ancilla[i - 1], qr_ancilla[i]], inplace=True
-                        )
+                        circuit.append(OrGate(2), [qr_state[i], qr_ancilla[i - 1], qr_ancilla[i]])
                     else:
                         circuit.ccx(qr_state[i], qr_ancilla[i - 1], qr_ancilla[i])
                 else:
                     if twos[i] == 1:
                         # OR needs the result argument as qubit not register, thus
                         # access the index [0]
-                        circuit.compose(
-                            OR(2), [qr_state[i], qr_ancilla[i - 1], q_compare], inplace=True
-                        )
+                        circuit.append(OrGate(2), [qr_state[i], qr_ancilla[i - 1], q_compare])
                     else:
                         circuit.ccx(qr_state[i], qr_ancilla[i - 1], q_compare)
 
@@ -66,9 +62,7 @@ def synth_integer_comparator_2s(
                         circuit.cx(qr_state[i], qr_ancilla[i])
                 else:
                     if twos[i] == 1:
-                        circuit.compose(
-                            OR(2), [qr_state[i], qr_ancilla[i - 1], qr_ancilla[i]], inplace=True
-                        )
+                        circuit.append(OrGate(2), [qr_state[i], qr_ancilla[i - 1], qr_ancilla[i]])
                     else:
                         circuit.ccx(qr_state[i], qr_ancilla[i - 1], qr_ancilla[i])
         else:

diff --git a/qiskit/synthesis/arithmetic/comparators/compare_greedy.py b/qiskit/synthesis/arithmetic/comparators/compare_greedy.py
@@ -13,7 +13,7 @@
 """Integer comparator based on 2s complement."""
 
 import numpy as np
-from qiskit.circuit import QuantumCircuit
+from qiskit.circuit.quantumcircuit import QuantumCircuit
 
 
 def synth_integer_comparator_greedy(

diff --git a/test/python/circuit/test_gate_definitions.py b/test/python/circuit/test_gate_definitions.py
@@ -360,6 +360,14 @@ class TestGateEquivalenceEqual(QiskitTestCase):
         "OrGate",
         "BitwiseXorGate",
         "InnerProductGate",
+        "IntegerComparatorGate",
+        "PolynomialPauliRotationsGate",
+        "PiecewiseLinearPauliRotationsGate",
+        "PiecewisePolynomialPauliRotationsGate",
+        "PiecewiseChebyshevGate",
+        "ExactReciprocalGate",
+        "LinearPauliRotationsGate",
+        "LinearAmplitudeFunctionGate",
     }
 
     # Amazingly, Python's scoping rules for class bodies means that this is the closest we can get