Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --dereference flag for cp #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use --dereference flag for cp #11

wants to merge 2 commits into from

Conversation

thenaterhood
Copy link

There's already a CreateLink, so there doesn't seem to be much point in copying symlinks. Using --dereference opens up more possibilities for storing config files.

There's already a CreateLink, so there doesn't seem to be much point in copying symlinks. Using --dereference opens up more possibilities for storing configs.
@CyberShadow
Copy link
Owner

This is a breaking change.

I suggest that you write a custom helper function.

@thenaterhood
Copy link
Author

I'm willing to do that. Would you be opposed to me adding another parameter to the existing CopyFile instead? That would keep backwards compatibility while avoiding a nearly duplicate function.

@CyberShadow
Copy link
Owner

I wouldn't be opposed to it if there was considerable demand for such a feature.

Otherwise, I'd like to keep the number of helper functions to the minimum required in normal usage. Since extensibility is not an issue, anyone can add their helper functions to their configuration (e.g. 10-helpers.sh), so there is no pressure to integrate them into the software itself. Perhaps the project wiki (or a page on the Arch wiki) would be a better place to collect potentially useful helpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants