Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to use S3 for reports and results #21

Merged
merged 13 commits into from
Sep 26, 2024

Conversation

Shelex
Copy link
Contributor

@Shelex Shelex commented Sep 19, 2024

Demo: https://cyborg-s3.shelex.dev/
Token: 12345

Added

  • split data file into separate fs for storage and pw for generating reports
  • common interface that is required to work with storage and apply to fs
  • added error handling for api routes
  • added loading for results/reports table as it may take some time to fetch with external storage option
  • added loading for deleting results/reports as it may take some time with external storage option
  • storage is configured with env variable DATA_STORAGE. If it is "s3" - it will use s3 client, otherwise fallback to "fs".
  • s3 storage implementation
  • use batches for reading and writing multiple files into s3 storage
  • move sorting reports and results on route level to work with s3 data as well

@Shelex Shelex marked this pull request as ready for review September 20, 2024 12:22
@Shelex Shelex requested review from Xotabu4 and mmtv-qa September 20, 2024 12:22
@Xotabu4
Copy link
Collaborator

Xotabu4 commented Sep 26, 2024

If you can update docs with how to configure this - i can merge this PR

@Shelex
Copy link
Contributor Author

Shelex commented Sep 26, 2024

If you can update docs with how to configure this - i can merge this PR

Please check updated readme documentation in fork: github.com/Shelex/playwright-reports-server/feat/useDataStorageS3

  • added table of contents
  • added "getting started" section which aggregates installation, setup and running service locally
  • added sections how to enable s3 storage
  • added section how to use docker image
  • fixed path for local fs folder (now we do not use /public to serve reports)

@Xotabu4 Xotabu4 merged commit ac5772a into CyborgTests:main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants