Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation for uploaded results, handle errors #33

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Shelex
Copy link
Contributor

@Shelex Shelex commented Oct 30, 2024

Rationale

Currently it is impossible to debug the report generation as few errors were handled during uploading.

Added

  • validate result file buffer which should be a zip file with pw-specific folder and file
  • add result file buffer validation to /api/result/upload endpoint
  • add more error handling to report index.html parser
  • show any stderr from playwright report generation
  • add more error handling to fs storage saving results

@Xotabu4 Xotabu4 merged commit 8289d29 into CyborgTests:main Oct 30, 2024
4 checks passed
@Shelex Shelex deleted the fix/validationForUploadedResults branch October 30, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants