-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/use service with cache for reports #43
Merged
Xotabu4
merged 18 commits into
CyborgTests:main
from
Shelex:feat/useServiceWithCacheForReports
Jan 11, 2025
Merged
Feat/use service with cache for reports #43
Xotabu4
merged 18 commits into
CyborgTests:main
from
Shelex:feat/useServiceWithCacheForReports
Jan 11, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d66d88e
to
afffd97
Compare
fix: specify types for reports storage and cache
Token input is now password type (so autocomplete will work) (CyborgTests#44) chore: increase readable stream watermark chore: try direct stream pipe chore: try streams manual event handling chore: use more granular stream events chore: check stream pipe with lower watermark chore: lower watermark, use stream pipeline chore: try converting writable to web chore: reduce watermark, use pipeline chore: try out limit watermark for writable stream as well chore: ensure binary encoding for streams
chore: increase stream watermark to reduce cpu overhead chore: check node v22 Revert "chore: check node v22" This reverts commit 3dea917.
chore: cleanup
1bdc0cc
to
6d0fbff
Compare
fix: handle s3 write for string content chore: revert to custom readable stream for s3 chore: try downgrading docker node version chore: explicitly turn off nextjs body parser for result upload chore: remove obsolete next route segment config
8af9a93
to
a7188cf
Compare
mmtv-qa
approved these changes
Dec 30, 2024
Xotabu4
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Issue:
Solution:
To make it simple stupid, plain
Map<string, entity>
should work fine, so no database would be required in the app setup.this allows us to have all parsed report data in the response and in future provide more data to the ui and quickly
this allows us to make interaction with s3 storage much efficient and avoid unnecessary queries
instead of reading entire file from formData into memory, utilize streams
Demo
S3
FS
BREAKING CHANGE
Changes