Feature/datarefs #106
Merged
Feature/datarefs #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO actually get data from the runner
instead of Data Refs
fde31
requested changes
Jun 11, 2024
| } | ||
| }; | ||
| this._ws.on("message", callback); | ||
| this._ws.send(cmd.packet()); |
There was a problem hiding this comment.
did you mean to use this._ws.sendPacket here?
There was a problem hiding this comment.
maybe :) this has been working for me but I'll look into it
There was a problem hiding this comment.
it might work but then the types need to be adjusted haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I certainly need some input on this one
contributes to #60