ZLOG0191: Use IFormattable instead of ISpanFormattable #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NM, was missing an IFormattable tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove net8.0 check for magicbox ToString IFormattable check
Unfortunately the previous fix didn't fully address this issue. When I was testing locally I was building the dll with net8.0 so everything was working as expected, so I didn't update this case, but the build released to NuGet, while supporting net8.0, doesn't apparently have NET8_0 defined when built so it still falls back into the JSON serializer instead of checking for IFormattable and appending as formatted.
Updated pull request with that check removed.