-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelism example #426
Parallelism example #426
Conversation
TBD why this is happening, but this is OK for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 4181b44 in 52 seconds
More details
- Looked at
30
lines of code in2
files - Skipped
1
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_iyE25ZZL5dPwaeGL
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
return inspect.getsource(self.__class__) | ||
try: | ||
return inspect.getsource(self.__class__) | ||
except Exception: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching a broad Exception
is not recommended as it can mask other issues. Consider catching specific exceptions like OSError
or TypeError
.
except Exception: | |
except OSError: |
A preview of 8100c66 is uploaded and can be seen here: ✨ https://burr.dagworks.io/pull/426 ✨ Changes may take a few minutes to propagate. Since this is a preview of production, content with |
4181b44
to
8100c66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 8100c66 in 8 seconds
More details
- Looked at
26
lines of code in2
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. examples/validate_examples.py:28
- Draft comment:
Consider marking this comment as a TODO for clarity, as it indicates a temporary state. - Reason this comment was not posted:
Confidence changes required:50%
The comment on line 28 indicates that the 'parallelism' directory is temporarily in the FILTERLIST and should be removed later. This is a placeholder comment and should be marked as a TODO for clarity.
Workflow ID: wflow_wbSYUXmrYvQq0qQd
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Need an example for parallelism -- this will be fixed up a bit later but I want to push out now
Important
Add parallelism example documentation and update
get_source()
inburr/core/action.py
to handle exceptions.get_source()
inburr/core/action.py
to return "No source available" if an exception occurs.examples/parallelism/README.md
to introduce Burr's parallelism capabilities with links to a notebook and a Loom video.FILTERLIST
invalidate_examples.py
to temporarily exclude it from validation.This description was created by for 8100c66. It will automatically update as commits are pushed.