Skip to content

Commit

Permalink
Apply suggestions from code review: fix typos in comments
Browse files Browse the repository at this point in the history
Co-authored-by: Lucas <[email protected]>
  • Loading branch information
dchiller and lucasmarchd01 committed Apr 22, 2024
1 parent a2893c7 commit bd15fa5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ flowchart TD
A --> J
```

*Note (1)*: Prefixes considered are "ab", "ob", "ad", "per", "sub", "in", "con" and "co". Prefixes are only removed when they are followed by a vowel; if not followed by a vowel, the rules regarding consonant placement are the same for the prefix as the rest of the word. An example will help illustrate. The word "perviam" should be syllabified "per-vi-am": the division of "rv" into two separate syllables follows the general rule of consonant placement (add the first consonant to the preceding syllable and the second consonant to the following syllable). The word "periurem", however, should be syllabified "per-iu-rem." Here, the general rule of consonant placement would call for the "r" to adhere to the following syllable. Because it is a prefix, however, the "r" stays in the first syllable.
*Note (1)*: Prefixes considered are "ab", "ob", "ad", "per", "sub", "in", "con", and "co". Prefixes are only removed when they are followed by a vowel; if not followed by a vowel, the rules regarding consonant placement are the same for the prefix as the rest of the word. An example will help illustrate. The word "perviam" should be syllabified "per-vi-am": the division of "rv" into two separate syllables follows the general rule of consonant placement (add the first consonant to the preceding syllable and the second consonant to the following syllable). The word "periurem", however, should be syllabified "per-iu-rem." Here, the general rule of consonant placement would call for the "r" to adhere to the following syllable. Because it is a prefix, however, the "r" stays in the first syllable.

*Note (2)*: Written "i"s and "y"s may be semivowels and written "u"s may be semi-vowels or consonants.
"I"s are semivowels:
Expand Down
4 changes: 2 additions & 2 deletions volpiano_display_utilities/latin_word_syllabification.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def split_word_by_syl_bounds(word: str, syl_bounds: List[int]) -> List[str]:
def _get_prefixes(word: str) -> str:
"""
Returns the prefix of a word, if it has one that is followed by a vowel.
FOr details on prefixes, see README.
For details on prefixes, see README.
word [str]: word to check for prefix
Expand All @@ -106,7 +106,7 @@ def _get_prefixes(word: str) -> str:
"""
for prefix in _PREFIX_GROUPS:
# If the word is itself one of the prefixes (eg. "in" can
# be a word or a prefix), doen't return a prefix
# be a word or a prefix), don't return a prefix
if word.startswith(prefix) and (word != prefix):
prefix_length = len(prefix)
if word[prefix_length] in _VOWELS:
Expand Down

0 comments on commit bd15fa5

Please sign in to comment.