Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended 'Save all chart images' button to allow subset of charts to be generated #1883

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

WolfyUK
Copy link
Collaborator

@WolfyUK WolfyUK commented Feb 3, 2025

Context

AB#248191 AB#245257 #1825

Change proposed in this pull request

  • Renamed <ModalSaveAllImages /> component to <ModalSaveImages />, but retained original functionality via optional prop
  • Refactored out ARIA progress component as well as modal/CTA components
  • List as checkboxes all charts to be generated, allowing user to un/check as required (default: all checked)
  • Validation error if no charts selected
  • Disable initial button press on Benchmark Spending pages until data loaded

Guidance to review

Dependency on #1825.

Checklist (add/remove as appropriate)

  • Work items have been linked (use AB#)
  • Your code builds clean without any errors or warnings
  • You have run all unit/integration tests and they pass
  • Your branch has been rebased onto main
  • You have tested by running locally
  • You have reviewed with UX/Design

@WolfyUK WolfyUK force-pushed the chore/248191/download-selected-modal branch 5 times, most recently from 0c99473 to bc9b9e7 Compare February 3, 2025 13:43
@WolfyUK WolfyUK force-pushed the chore/248191/download-selected-modal branch from fdacc83 to 912f3a7 Compare February 7, 2025 14:37
@WolfyUK WolfyUK marked this pull request as ready for review February 7, 2025 14:46
@WolfyUK WolfyUK marked this pull request as draft February 7, 2025 14:49
@WolfyUK WolfyUK marked this pull request as ready for review February 7, 2025 17:09
@WolfyUK WolfyUK force-pushed the chore/248191/download-selected-modal branch from 912f3a7 to 3945e9a Compare February 7, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant