Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add personal info to filtered params config #159

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

peteryates
Copy link
Member

@shaheislamdfe pointed out we weren't filtering email addresses out of logs.

This change adds fields containing personal information to Rails' list of filter_parameters.

Changes

  • Reformat and sort the filter param list
  • Filter params that might contain personal data

Testing

Checking the logs with this enabled we can see:

Parameters: {"authenticity_token"=>"[FILTERED]", "email"=>"[FILTERED]", "name"=>"[FILTERED]", "appropriate_body_id"=>"5", "school_urn"=>"", "dfe_staff"=>"false", "commit"=>"[FILTERED]", "provider"=>"persona"}

Started GET "/appropriate-body/teachers?q=[FILTERED]" for 127.0.0.1 at 2025-02-07 15:12:20 +0000

Processing by OTPSessionsController#create as HTML
  Parameters: {"authenticity_token"=>"[FILTERED]", "sessions_otp_sign_in_form"=>"[FILTERED]"}

Review notes

Did I miss any personal fields?

@peteryates peteryates requested a review from a team February 7, 2025 15:15
Copy link

github-actions bot commented Feb 7, 2025

Review app deployed to https://cpd-ec2-review-159-web.test.teacherservices.cloud

@peteryates peteryates force-pushed the add-personal-info-to-filtered-params branch from a25514f to cd971db Compare February 14, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants