-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add personal info to filtered params config #159
Open
peteryates
wants to merge
5
commits into
main
Choose a base branch
from
add-personal-info-to-filtered-params
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review app deployed to https://cpd-ec2-review-159-web.test.teacherservices.cloud |
c88811d
to
dcfbfdc
Compare
dcfbfdc
to
8c10fd9
Compare
leoapost
reviewed
Feb 14, 2025
leoapost
reviewed
Feb 14, 2025
leoapost
reviewed
Feb 14, 2025
Co-authored-by: tonyheadford <[email protected]> Co-authored-by: leoapost <[email protected]> Co-authored-by: peterdavidhamilton <[email protected]>
Co-authored-by: Leonidas Apostolidis <[email protected]>
Co-authored-by: Leonidas Apostolidis <[email protected]>
a25514f
to
cd971db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shaheislamdfe pointed out we weren't filtering email addresses out of logs.
This change adds fields containing personal information to Rails' list of
filter_parameters
.Changes
Testing
Checking the logs with this enabled we can see:
Review notes
Did I miss any personal fields?