Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor bugs in the Datumaro integration #400

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fix minor bugs in the Datumaro integration #400

merged 2 commits into from
Jul 22, 2024

Conversation

jarkenau
Copy link
Member

@jarkenau jarkenau commented Jul 22, 2024 •
edited
Loading

  • 9a0b782 fixes the incorrect assignment of the labelID as the instanceID in the Flatbuffer core conversions
  • b498056 adds default values to the core label message, otherwise an unset UUID will be interpreted as a valid instanceID that doesn't exist.

@jarkenau jarkenau added the fix label Jul 22, 2024
@jarkenau jarkenau self-assigned this Jul 22, 2024
@jarkenau jarkenau enabled auto-merge July 22, 2024 07:33
@jarkenau jarkenau merged commit b3f61d8 into main Jul 22, 2024
9 checks passed
@jarkenau jarkenau deleted the fix/datumaro-integration-bugs branch July 22, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmeijerdfki mmeijerdfki mmeijerdfki approved these changes

@Mark-Niemeyer Mark-Niemeyer Awaiting requested review from Mark-Niemeyer

Assignees

@jarkenau jarkenau

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarkenau @mmeijerdfki