v0.9.0 update batch

.github/workflows/build.yml

@@ -23,10 +23,16 @@ jobs:
         with:
           jvm: adopt:16
           apps: sbt bloop
-      - name: Setup Simulation Tools
+      - name: Setup All Simulation Tools but NVC
         uses: YosysHQ/setup-oss-cad-suite@v3
+      - name: Setup Homebrew (for NVC)
+        uses: Homebrew/actions/setup-homebrew@master
+      - name: Setup NVC
+        run: brew install nvc
       - run: |
           verilator -version
+          iverilog -V
           ghdl version
+          nvc --version
       - name: Run tests
         run: sbt test

.gitignore

@@ -1,6 +1,7 @@
 myenv/**
 out/
 .idea/
+.cache/
 /.bsp/
 project/project
 project/target

.scalafmt.conf

@@ -3,6 +3,8 @@ runner.dialect = scala3
 
 maxColumn = 100
 
+assumeStandardLibraryStripMargin = true
+align.stripMargin = true
 rewrite.scala3.removeOptionalBraces = oldSyntaxToo
 rewrite.scala3.insertEndMarkerMinLines = 15
 

build.sbt

@@ -2,7 +2,7 @@ commands += DFHDLCommands.quickTestSetup
 
 // format: off
 val projectName = "dfhdl"
-val compilerVersion = "3.5.1"
+val compilerVersion = "3.5.2"
 
 inThisBuild(
   List(

compiler/ir/src/main/scala/dfhdl/compiler/analysis/DFValAnalysis.scala

@@ -406,3 +406,11 @@ extension (net: DFNet)
       case DFNet(DFRef(lhs: DFVal), _, DFRef(rhs: DFVal), _, _, _) =>
         lhs.collectRelMembers(false) ++ rhs.collectRelMembers(false)
       case _ => Nil
+
+extension (member: DFMember)
+  def isPublicMember(using MemberGetSet): Boolean =
+    member match
+      case DclPort()      => true
+      case DesignParam(_) => true
+      case _: DomainBlock => true
+      case _              => false

compiler/ir/src/main/scala/dfhdl/compiler/ir/Config.scala

@@ -61,6 +61,10 @@ enum RTDomainCfg extends HasRefCompare[RTDomainCfg] derives CanEqual:
   lazy val getRefs: List[DFRef.TwoWayAny] = this match
     case Related(relatedDomainRef) => List(relatedDomainRef)
     case _                         => Nil
+
+  def copyWithNewRefs: this.type = this match
+    case Related(relatedDomainRef) => Related(relatedDomainRef.copyAsNewRef).asInstanceOf[this.type]
+    case _                         => this
 end RTDomainCfg
 
 object RTDomainCfg:

compiler/ir/src/main/scala/dfhdl/compiler/ir/DB.scala

@@ -19,6 +19,8 @@ final case class DB(
     val designDB: DB = self
     def apply[M <: DFMember, M0 <: M](ref: DFRef[M]): M0 =
       refTable(ref).asInstanceOf[M0]
+    def getOption[M <: DFMember, M0 <: M](ref: DFRef[M]): Option[M0] =
+      refTable.get(ref).asInstanceOf[Option[M0]]
     def getOrigin(ref: DFRef.TwoWayAny): DFMember = originRefTable(ref)
     def set[M <: DFMember](originalMember: M)(newMemberFunc: M => M): M =
       newMemberFunc(originalMember)
@@ -60,7 +62,7 @@ final case class DB(
 
   lazy val top: DFDesignBlock = membersNoGlobals.head match
     case m: DFDesignBlock => m
-    case _                => throw new IllegalArgumentException("Unexpected member as Top.")
+    case invalidTop => throw new IllegalArgumentException(s"Unexpected member as Top:\n$invalidTop")
 
   lazy val memberTable: Map[DFMember, Set[DFRefAny]] = refTable.invert
 
@@ -417,7 +419,7 @@ final case class DB(
                 if (prevNet.getOwnerDomain != net.getOwnerDomain)
                   newError(
                     s"""|Found multiple domain assignments to the same variable/port `${toDcl
-                         .getFullName}`
+                         .getFullName}`.
                         |Only variables declared as `VAR.SHARED` under ED domain allow this.
                         |The previous write occurred at ${prevNet.meta.position}""".stripMargin
                   )
@@ -428,7 +430,7 @@ final case class DB(
               if (prevNet.isConnection || prevNet.isAssignment && !net.isAssignment)
                 newError(
                   s"""Found multiple connections write to the same variable/port `${toDcl
-                      .getFullName}`
+                      .getFullName}`.
                      |The previous write occurred at ${prevNet.meta.position}""".stripMargin
                 )
             // if no previous connection in this range, we add it to the range map
@@ -461,7 +463,8 @@ final case class DB(
                |Unable to determine directionality for the following nets:
                |${pendingNets.map(_.net.meta.position).mkString("\n")}""".stripMargin
           )
-      case Nil => connToDcls
+      case Nil =>
+        connToDcls
     end match
   end getConnToDcls
 
@@ -484,14 +487,6 @@ final case class DB(
       //       |Hierarchy: ${targetPort.getOwnerNamed.getFullName}""".stripMargin
       // )
       None
-    // count the hierarchy distance from inside to outside
-    def distance(inside: DFDesignBlock, outside: DFDesignBlock): Int =
-      var distance = 0
-      var dsn = inside
-      while (dsn != outside)
-        distance = distance + 1
-        dsn = dsn.getOwnerDesign
-      return distance
     // group magnet ports according to the magnet type
     val magnetDclGroups =
       members.view
@@ -533,14 +528,18 @@ final case class DB(
                 port.isPortIn && !port.isSameOwnerDesignAs(targetPort) &&
                 targetPort.isInsideOwner(port.getOwnerDesign)
               }.map { port =>
-                (port, distance(targetDsn, port.getOwnerDesign))
+                (port, targetDsn.getDistanceFromOwnerDesign(port.getOwnerDesign))
               }.toList.sortBy(_._2)
               // sorted source out port candidates according to the distance
               val sourceOutCandidates = dclGrp.filter(_.isPortOut)
                 .map { port =>
                   val portDsn = port.getOwnerDesign
                   val commonDesign = targetDsn.getCommonDesignWith(portDsn)
-                  (port, distance(targetDsn, commonDesign), distance(portDsn, commonDesign))
+                  (
+                    port,
+                    targetDsn.getDistanceFromOwnerDesign(commonDesign),
+                    portDsn.getDistanceFromOwnerDesign(commonDesign)
+                  )
                 }.toList.sortBy(_._3).sortBy(_._2)
               (sourceInCandidates, sourceOutCandidates) match
                 case (Nil, Nil) =>
@@ -569,7 +568,7 @@ final case class DB(
                 port.isPortOut && !port.isSameOwnerDesignAs(targetPort) &&
                 port.isInsideOwner(targetDsn)
               }.map { port =>
-                (port, distance(port.getOwnerDesign, targetDsn))
+                (port, port.getDistanceFromOwnerDesign(targetDsn))
               }.toList.sortBy(_._2)
               sourceOutCandidates match
                 case Nil =>
@@ -603,6 +602,24 @@ final case class DB(
     ret
   end magnetConnectionTable
 
+  def checkDanglingInputs(): Unit =
+    // collect all input ports that are not connected directly or implicitly as magnets
+    val danglingInputs = members.collect {
+      case p: DFVal.Dcl
+          if p.isPortIn && !connectionTable.contains(p) &&
+            !p.getOwnerDesign.isTop && !magnetConnectionTable.contains(p) =>
+        val ownerDesign = p.getOwnerDesign
+        s"""|DFiant HDL connectivity error!
+            |Position:  ${ownerDesign.meta.position}
+            |Hierarchy: ${ownerDesign.getFullName}
+            |Message:   Found a dangling (unconnected) input port `${p.getName}`.""".stripMargin
+    }
+    if (danglingInputs.nonEmpty)
+      throw new IllegalArgumentException(
+        danglingInputs.mkString("\n")
+      )
+  end checkDanglingInputs
+
   // holds for each RTDomain/RTDesign/RTInterface that its configuration on another domain,
   // the domain it is dependent on
   lazy val dependentRTDomainOwners: Map[DFDomainOwner, DFDomainOwner] =
@@ -788,6 +805,7 @@ final case class DB(
     nameCheck()
     connectionTable // causes connectivity checks
     magnetConnectionTable // causes magnet connectivity checks
+    checkDanglingInputs()
     directRefCheck()
     circularDerivedDomainsCheck()
 
@@ -833,6 +851,7 @@ enum MemberView derives CanEqual:
 trait MemberGetSet:
   def designDB: DB
   def apply[M <: DFMember, M0 <: M](ref: DFRef[M]): M0
+  def getOption[M <: DFMember, M0 <: M](ref: DFRef[M]): Option[M0]
   def getOrigin(ref: DFRef.TwoWayAny): DFMember
   def set[M <: DFMember](originalMember: M)(newMemberFunc: M => M): M
   def replace[M <: DFMember](originalMember: M)(newMember: M): M